Allow REPL to start without dump path

dotnet · Dec 28, 2024 · 7453831 · 7453831
1 parent 25f53c8
commit 7453831
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/Tools/dotnet-dump/Analyzer.cs b/src/Tools/dotnet-dump/Analyzer.cs
@@ -38,8 +38,6 @@ public Analyzer()
 
         public Task<int> Analyze(FileInfo dump_path, string[] command)
         {
-            _fileLoggingConsoleService.WriteLine($"Loading core dump: {dump_path} ...");
-
             // Attempt to load the persisted command history
             string historyFileName = null;
             try
@@ -97,13 +95,17 @@ or NotSupportedException
 
             try
             {
-                ITarget target = dumpTargetFactory.OpenDump(dump_path.FullName);
-                contextService.SetCurrentTarget(target);
-
                 // Automatically enable symbol server support, default cache and search for symbols in the dump directory
                 symbolService.AddSymbolServer(retryCount: 3);
                 symbolService.AddCachePath(symbolService.DefaultSymbolCache);
-                symbolService.AddDirectoryPath(Path.GetDirectoryName(dump_path.FullName));
+
+                if (dump_path is not null)
+                {
+                    _fileLoggingConsoleService.WriteLine($"Loading core dump: {dump_path} ...");
+                    ITarget target = dumpTargetFactory.OpenDump(dump_path.FullName);
+                    contextService.SetCurrentTarget(target);
+                    symbolService.AddDirectoryPath(Path.GetDirectoryName(dump_path.FullName));
+                }
 
                 // Run the commands from the dotnet-dump command line. Any errors/exceptions from the
                 // command execution will be displayed and dotnet-dump exited.

diff --git a/src/Tools/dotnet-dump/Program.cs b/src/Tools/dotnet-dump/Program.cs
@@ -101,7 +101,8 @@ private static Argument DumpPath() =>
             new Argument<FileInfo>(
                 name: "dump_path")
             {
-                Description = "Name of the dump file to analyze."
+                Description = "Name of the dump file to analyze.",
+                Arity = ArgumentArity.ZeroOrOne
             }.ExistingOnly();
 
         private static Option RunCommand() =>