-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALTER_QUERY::FIXED:: Also rename __schema__ document for renamed collection #688
Open
frikilax
wants to merge
681
commits into
doableware:master
Choose a base branch
from
VultureProject:fix_model_renaming_schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ALTER_QUERY::FIXED:: Also rename __schema__ document for renamed collection #688
frikilax
wants to merge
681
commits into
doableware:master
from
VultureProject:fix_model_renaming_schema
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pymongo has its own version of bson, which is incompatible with the package Dataclasses is included for versions over python 3.6, making it unnecessary to install
Bug fixes and other improvements
MongoClient specific parameters moved to client dict
Good catch |
bec8e6a
to
5507210
Compare
49a3eb5
to
ce0b58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing a migration including
RenameModel()
operations, collections are correctly reamed, but not their corresponding schema document, resulting in out-of-sync database information for fields and auto-incremental primary IDsHow to reproduce
Implications
After launching the 2 migrations, schema document is not synced with the latest Model name, so new Model instances are created without the incremental ID value