Add a special case for how S3 requests should be signed #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
commented
Oct 2, 2024
| authHeader ++ baseHeaders | ||
| } | ||
| (request: Request[F]) => | ||
| preSign(request).flatMap { case (payloadHash, preparedRequest) => |
There was a problem hiding this comment.
This PR is best compared side-by-side (split) in github, with whitespace hidden. This is one of the important changes
kubukoz
reviewed
Oct 2, 2024
modules/aws-http4s/test/src-jvm/smithy4s/aws/internals/AwsSignatureTest.scala
Show resolved
Hide resolved
kubukoz
reviewed
Oct 2, 2024
kubukoz
reviewed
Jan 2, 2025
kubukoz
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 enforces the presence of the
X-AMZ-CONTENT-SHA256header. This PR adds the necessary logic to special case this addition, and tests it against the S3-specific signer provided by the official java AWS SDK.Replaces #1560
PR Checklist (not all items are relevant to all PRs)