use field.getUnlessDefault instead of field.get in UrlFormDataEncoder

disneystreaming · Dec 8, 2023 · afb678c · afb678c
1 parent 4b7a8b1
commit afb678c
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/modules/core/src/smithy4s/http/internals/UrlFormDataEncoderSchemaVisitor.scala b/modules/core/src/smithy4s/http/internals/UrlFormDataEncoderSchemaVisitor.scala
@@ -136,8 +136,14 @@ private[http] class UrlFormDataEncoderSchemaVisitor(
       make: IndexedSeq[Any] => S
   ): UrlFormDataEncoder[S] = {
     def fieldEncoder[A](field: Field[S, A]): UrlFormDataEncoder[S] =
-      compile(field.schema)
-        .contramap(field.get)
+      new UrlFormDataEncoder[S] {
+        private lazy val cachedEncoder = compile(field.schema)
+        override def encode(value: S): List[UrlForm.FormData] =
+          field
+            .getUnlessDefault(value)
+            .toList
+            .flatMap(cachedEncoder.encode)
+      }
         .prepend(getKey(field.hints, field.label))
     val encoders = fields.map(fieldEncoder(_))
     struct => encoders.toList.flatMap(_.encode(struct))