Skip to content

Commit

Permalink
Don't require -Wextra goto-gcc flag for warnings to be treated as errors
Browse files Browse the repository at this point in the history
The new version is not completely equivalent to how it would work in
gcc. In gcc, when both -Werror and -Wno-error are given (possibly
multiple times), the flag that was given last "wins". However we
currently don't have a way of knowing the order of options in cmdlinet.
  • Loading branch information
danpoe committed Jun 24, 2020
1 parent 823782c commit 188a69f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/goto-cc/gcc_mode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,6 @@ int gcc_modet::doit()
compilet compiler(cmdline,
gcc_message_handler,
cmdline.isset("Werror") &&
cmdline.isset("Wextra") &&
!cmdline.isset("Wno-error"));

if(cmdline.isset("version"))
Expand Down

0 comments on commit 188a69f

Please sign in to comment.