<to-do> #89

snuggs · 2017-07-06T06:56:49Z

Fixes #85

brandondees · 2017-07-06T07:12:58Z

http://todomvc.com/

snuggs · 2017-07-06T07:44:45Z

@brandondees already on it.

snuggs · 2017-07-06T08:31:50Z

@tmornini @brandondees First working pass

snuggs · 2017-07-06T08:53:52Z

https://github.com/tastejs/todomvc-app-template

@brandondees this is rediculous the amount of code they want you to have for their boilerplate. I feel we should have a <to-do> and <to-do-mvc> custom element. One for OUR conventions. And the latter for us to abide by what they consider a "working TODO Example" which truth be told is about 60% more code than is needed.

Please advise...

/cc @tmornini @halorium

brandondees · 2017-07-06T09:06:53Z

yeah i agree but it still helps advertise if we can play by their rules to at least be in the game, i think. then also do the lighter variant and make a hullabaloo about how the snuggsi way is even better faster stronger and can still pass all the acceptance tests. you might look at how other tools have done their entries, i assume stuff like polymer is represented already and might give you some idea of ways this competition can be approached.

tmornini · 2017-07-06T22:36:42Z

@snuggs You need to speed things up a bit.

The app loads and runs slowly and it took you way more than 12 hours to get this done. 😄

Oh, and while you're at it, this has way too few commits. Break that shit up! 👍

tmornini · 2017-07-06T22:37:20Z

@halorium Your name in lights!

snuggs · 2017-07-07T01:49:39Z

@tmornini Minus filtering been done. Looks like we're coming in under 100LOC (Whitespace included). Prunin' the bonzai bush. Take a look @ React while you wait. https://github.com/tastejs/todomvc/tree/gh-pages/examples/react/js

/cc @brandondees @halorium

tmornini · 2017-07-07T05:09:50Z

@snuggs I count 181+62+108+87+50 = 488 LOC for React

tmornini · 2017-07-07T05:15:01Z

index.html

@@ -602,6 +602,9 @@ <h2 slot=header>
          <a href=/examples/input-output.html>&lt;input-output&gt;</a>

        <li>
+          <a href=/examples/to-do>&lt;to-do&gt;</a>


Is this valid? The <li> doesn't appear to be closed.

http://networkingtimes.com/blog/wp-content/uploads/2015/10/closing.gif

HTML5 is way less strict than the XHTML which became best practice for a while... closing tags are mostly optional. how does it work? ¯\(ツ)/¯

@tmornini there's TONS of them actually. Been in the spec (even IE6) since like 2000. DOM Level 2.

Surprised you didn't say anything about <html> the <body> tag and the <head> tag... or lack thereof ;-)
https://www.w3.org/TR/html5/syntax.html#optional-tags

@brandondees HOW it does it is the following DOMParser logic that runs. It's different per element but this is the spec rules for <p> /cc @tmornini

Correction. Looks like since 1999 DOM Level 0 @tmornini. Article came out in 2008 and author basically stated "9 years later the information still isn't out there" https://meiert.com/en/blog/optional-tags-in-html-4/

tmornini · 2017-07-07T05:16:18Z

examples/to-do/index.es

+  get count ()
+    { return this.context.tasks.length }
+})
+


You mentioned a blank line at the bottom of source files and mentioned that they're for me.

I don't like blank lines at the bottom. I think you're thinking of no line ending on the last line, which I think is horrible. 😄

What is a line ending? Now i'm confused @tmornini

tmornini · 2017-07-07T18:01:35Z

Surprised you didn't say anything about

@snuggs Just a drive-by-review. Squirrel! 😄

snuggs · 2017-07-07T18:03:27Z

Functionality complete. @halorium @tmornini. Givin' 'er a paint job now.

tmornini · 2017-07-07T18:11:38Z

@snuggs Looking good! 🍿

…gories

…tmornini

…tmornini

snuggs · 2017-07-19T02:35:46Z

@brandondees @mrbernnz @tmornini @halorium @btakita @kurtcagle @dcchuck @janz93 @pachonk @henryarbolaez @Robertchristopher

BEHOLD! https://snuggsi-kwwwdjwzvw.now.sh/examples/to-do

brandondees · 2017-07-19T02:55:37Z

examples/to-do/index.es

@@ -0,0 +1,78 @@
+Element `to-do`
+


i have mixed feels about this blank line... i think it works great when it's one file per element declaration, nothing else in the file. if it's inline with other content, such as in html or whatever, then i think you gotta have visual grouping of related code more.

Hmm well best part is it's just whitespace so we can author how we please. :-) @brandondees

yeah just commenting

brandondees · 2017-07-19T03:12:38Z

examples/to-do/index.es

+  }
+
+
+  onidle (mark) {


when does this run? frequently? seems like it might be doing wasteful work if so. might be able to optimize with a dirty checking mechanism for eager exit

@brandondees it runs after render. We have to do this or creates logic in view. Currently this operation takes about 100mu

brandondees · 2017-07-19T03:18:20Z

mixins/storable.es

+
+  store (id=this.tagName) {
+    localStorage.setItem
+      (id, JSON.stringify (this.context))


this seems like a pretty naive approach but no worries there, given the use case. I wonder if it could be named something clearer, like SimpleStorableStateElement or whatever to clarify purpose/intent a bit more.

brandondees

see comments, but LGTM

snuggs added 📝 DOCUMENTATION 📝 🎁 FEATURE 🎁 🚧 WIP 🚧 labels Jul 6, 2017

snuggs requested review from tmornini and brandondees July 6, 2017 06:56

snuggs force-pushed the feature/85-to-do branch from bbc96dc to 6b8b587 Compare July 6, 2017 07:04

snuggs mentioned this pull request Jul 6, 2017

<to-do> #85

Closed

snuggs force-pushed the feature/85-to-do branch 6 times, most recently from 5fdde0e to ba01a45 Compare July 6, 2017 18:36

snuggs force-pushed the feature/85-to-do branch from fd5e511 to e1b8e59 Compare July 7, 2017 01:41

tmornini reviewed Jul 7, 2017

View reviewed changes

snuggs mentioned this pull request Jul 7, 2017

📖 Update Current Microsoft Browser to IE11/Edge tastejs/todomvc#1796

Merged

snuggs force-pushed the feature/85-to-do branch from b1ad6f0 to c3b96c2 Compare July 7, 2017 14:57

snuggs added 20 commits July 18, 2017 22:32

Update button text to shorter words

81f6cef

Fix whitespace for state machine

72f1c94

Update margins and spacing

560b74f

Hover state for menu

0e99325

set maxlength of input used in task name

408785c

Increase visibility of buttons

b1d5f8f

fix visibility of footer based on tasks

0a59edd

Add CSS Counter logic for task categories

2216e2c

Some minor whitespace formatting for to-do styles

5dc82ab

Some minor whitespace formatting for to-do styles

01bfc46

Implement common data-count data attribute for respective task cate…

8601c95

…gories

Update sytling for menu CSS counters

a3fb615

Update Button label to say 'Done'

7594a39

Update styles

62296de

Rename styles.css to style.css

748d2c3

Migrate SVG background images into CSS file

db348ba

Adjust margin for Add button

e437f33

Add hover effect to task

161ad27

Add Storable Mixin. That was easy! @haloreum @mrbernnz @brandondees @…

7f59c57

…tmornini

Add SVG CSS Base64 Images

0ba4763

snuggs force-pushed the feature/85-to-do branch from 661121e to 0ba4763 Compare July 19, 2017 02:32

snuggs added 📜 PROPOSAL📜 and removed 🚧 WIP 🚧 labels Jul 19, 2017

brandondees reviewed Jul 19, 2017

View reviewed changes

brandondees approved these changes Jul 19, 2017

View reviewed changes

snuggs merged commit 1914a86 into master Jul 19, 2017

snuggs deleted the feature/85-to-do branch July 19, 2017 03:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

<to-do> #89

<to-do> #89

snuggs commented Jul 6, 2017 •

edited

Loading

brandondees commented Jul 6, 2017

snuggs commented Jul 6, 2017

snuggs commented Jul 6, 2017

snuggs commented Jul 6, 2017 •

edited

Loading

brandondees commented Jul 6, 2017

tmornini commented Jul 6, 2017 •

edited

Loading

tmornini commented Jul 6, 2017

snuggs commented Jul 7, 2017

tmornini commented Jul 7, 2017

tmornini Jul 7, 2017 •

edited

Loading

brandondees Jul 7, 2017 •

edited

Loading

snuggs Jul 7, 2017

snuggs Jul 7, 2017 •

edited

Loading

snuggs Jul 7, 2017 •

edited

Loading

tmornini Jul 7, 2017

snuggs Jul 7, 2017 •

edited

Loading

tmornini commented Jul 7, 2017

snuggs commented Jul 7, 2017 •

edited

Loading

tmornini commented Jul 7, 2017

snuggs commented Jul 19, 2017 •

edited

Loading

brandondees Jul 19, 2017

snuggs Jul 19, 2017

brandondees Jul 19, 2017

brandondees Jul 19, 2017

snuggs Jul 19, 2017

brandondees Jul 19, 2017

brandondees left a comment

<to-do> #89

<to-do> #89

Conversation

snuggs commented Jul 6, 2017 • edited Loading

brandondees commented Jul 6, 2017

snuggs commented Jul 6, 2017

snuggs commented Jul 6, 2017

snuggs commented Jul 6, 2017 • edited Loading

brandondees commented Jul 6, 2017

tmornini commented Jul 6, 2017 • edited Loading

tmornini commented Jul 6, 2017

snuggs commented Jul 7, 2017

tmornini commented Jul 7, 2017

tmornini Jul 7, 2017 • edited Loading

Choose a reason for hiding this comment

brandondees Jul 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snuggs Jul 7, 2017 • edited Loading

Choose a reason for hiding this comment

snuggs Jul 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snuggs Jul 7, 2017 • edited Loading

Choose a reason for hiding this comment

tmornini commented Jul 7, 2017

snuggs commented Jul 7, 2017 • edited Loading

tmornini commented Jul 7, 2017

snuggs commented Jul 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brandondees left a comment

Choose a reason for hiding this comment

snuggs commented Jul 6, 2017 •

edited

Loading

snuggs commented Jul 6, 2017 •

edited

Loading

tmornini commented Jul 6, 2017 •

edited

Loading

tmornini Jul 7, 2017 •

edited

Loading

brandondees Jul 7, 2017 •

edited

Loading

snuggs Jul 7, 2017 •

edited

Loading

snuggs Jul 7, 2017 •

edited

Loading

snuggs Jul 7, 2017 •

edited

Loading

snuggs commented Jul 7, 2017 •

edited

Loading

snuggs commented Jul 19, 2017 •

edited

Loading