-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ 📖 DRAFT: <tag-complete> #117
base: main
Are you sure you want to change the base?
Conversation
examples/email-recipients/index.html
Outdated
<email-recipients> | ||
|
||
<template name=recipients> | ||
<address> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is address allowed to be email address, not just physical? TIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandondees. May want to ask @kurtcagle or @janz93 @mrbernnz
|
||
</script> | ||
|
||
<script src=/browser-sync.es></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we load this conditionally based on localhost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, hadn't picked up on that. well played.
examples/email-recipients/style.css
Outdated
|
||
email-recipients > address:hover, | ||
email-recipients { | ||
box-shadow: 0 0 0.28em rgba(40,40,40,0.8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no spaces between rgba values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandondees i'm down with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertoponti @brandondees hit me with "Tsu"! f783911
@brandondees @kurtcagle name rechange to |
yeah generalize the names to what the component actually does, rather than the specific use case for it. be sure to list known use-cases in the documentation but I'm all for more generic components. |
a consumer can always wrap them in their own context-specific name at import time, btw |
@brandondees OR use an identifier |
no i mean |
<tag-complete>
Inspiration drawn from @kurtcagle's tags. @kurtcagle if you can drop the codepen in the description that would be great. Also gives you the chance to catch up to speed with the lifecycle callbacks.
https://snuggsi.now.sh#lifecycle please give it a moment as there is a 30s warmup time with the free plan at https://now.sh
Coparable Examples
Demonstration