nflgame.live run with Threading

[tkutcher]

See #78

Changes

• stop_event parameter added to run() in nflgame.live
  • Should be a https://docs.python.org/3/library/threading.html#event-objects object
  • If none provided, creates local threading.Event variable that just never gets set
  • time.sleep() changed to `threading.Event.wait()
  • stop renamed to stop_date to better distinguish between the two
• LiveRunner class to call run in a thread, with a shutdown() method to shutdown gracefully

Notes

• Didn't exactly test it / not sure how to test it (other than waiting for live games then just manually checking some debugging logs)
• Refactored some of the logic using ternary operator (if that's against typical style I'll take it out)
  • Also left a TODO comment in that can do the same thing the if-else above it.
• Another thought that could clean up the code is if a stop_date is provided, just set a timer that sets the stop_event. e.g.

if stop_date is not None:
    wait_time = # some expression
    t = threading.Timer(wait_time, lambda: stop_event.set())

[derek-adair]

This component was in "alpha status" so there is a pretty low barrier to entry to modify this one. As far as i can tell testing this would require some sophisticated mocks that create game(s) in the past, present and future, with some kind of "time traveling" that adjusts the time. Not sure what that would look like.

[tkutcher]

Got it - I'll mark as ready!

[derek-adair]

Good work, i'll be testing this locally tomorrow.