Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require explicit-function-return-type #1781

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

samayer12
Copy link
Contributor

Description

Promotes linter rule from a warning to an error.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1780

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (7cc69ea) to head (5ac5a41).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          52       52           
  Lines        2214     2214           
  Branches      436      469   +33     
=======================================
  Hits         1818     1818           
+ Misses        394      367   -27     
- Partials        2       29   +27     

see 7 files with indirect coverage changes

@samayer12 samayer12 changed the title Promote explicit-function-return-type to a linting error chore: require explicit-function-return-type Feb 7, 2025
@samayer12 samayer12 marked this pull request as ready for review February 7, 2025 17:32
@samayer12 samayer12 requested a review from a team as a code owner February 7, 2025 17:32
@cmwylie19 cmwylie19 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 517bbd6 Feb 7, 2025
48 checks passed
@cmwylie19 cmwylie19 deleted the 1780-linter-settings branch February 7, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Require explicit-function-return-type
2 participants