-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor watch processor test to reduce redundancy #1763
chore: refactor watch processor test to reduce redundancy #1763
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1763 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 52 52
Lines 2214 2214
Branches 470 469 -1
=======================================
Hits 1818 1818
- Misses 367 394 +27
+ Partials 29 2 -27 |
@tamirazrab I took at look at the test refactor and noticed there was an issue with resetting mocks between assertions. I reintroduced the manual mock-resets to get the tests to pass. As a follow-on item, we should consider the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improving the test quality here can take multiple PRs, which is okay. This PR extracts the repeated assertions into a helper function used by a test.
129376b
Description
Resolve max-statements warning in src/lib/processors/watch-processor.test.ts
...
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Fixes #1696
Type of change
Checklist before merging