-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: max-statements warning in src/cli/init/index.ts #1729
base: main
Are you sure you want to change the base?
chore: max-statements warning in src/cli/init/index.ts #1729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! While reviewing, I noticed that genPeprTS()
wasn't actually doing anything that couldn't be solved by referencing a const. So, as a bonus, the refactored setupProjectStructure()
function only requires two input parameters.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
+ Coverage 82.05% 82.08% +0.03%
==========================================
Files 52 52
Lines 2212 2211 -1
Branches 470 470
==========================================
Hits 1815 1815
+ Misses 368 367 -1
Partials 29 29
|
Signed-off-by: t.azrab <[email protected]>
…razrab/pepr into 1693-resolve-max-statement-cli-init
Looks much clean now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is not getting generated during the npx pepr build -i pepr:dev
as CI is not passing for 2 jobs consistently
This needs a little investigation
https://github.com/defenseunicorns/pepr/actions/runs/13012979379/job/36295073948?pr=1729
One way to test the build is create the pepr test module:
pepr $> npm test
When the pepr-test-module
directory is created you can test the build. This allows you to step through the build code and make sure the dist folder is there with the correct files. I will try to find some time to look into this too very soon because I am not sure why the code I am seeing may not be generating some build artifact
pepr/pepr-test-module $> npx ts-node ../src/cli.ts build
Description
...
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Fixes #1693
Type of change
Checklist before merging