-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: max-params warning for src/sdk/sdk.ts #1728
base: main
Are you sure you want to change the base?
chore: max-params warning for src/sdk/sdk.ts #1728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but this is user facing breaking change
https://docs.pepr.dev/main/user-guide/sdk/#writeevent
We would need to deprecate before making this change. We will chat as a team and give you some feedback. Thanks for the PR
resolves defenseunicorns#1700 Signed-off-by: t.azrab <[email protected]>
…pr into 1700-resolve-max-param-sdk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1728 +/- ##
=======================================
Coverage 82.11% 82.12%
=======================================
Files 52 52
Lines 2214 2215 +1
Branches 459 469 +10
=======================================
+ Hits 1818 1819 +1
- Misses 367 394 +27
+ Partials 29 2 -27
|
As an update, we're still thinking about how we want to approach the underlying program structure that caused this warning. In general, we prefer to avoid resolving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we will leave a message in our release about this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a plan to communicate this breaking change to users, good to go!
Description
Resolve
max-params
warning forsrc/sdk/sdk.ts
...
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Relates to #1700
Type of change
Checklist before merging