update service endpoint section #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LMAO, I just did a PR for this too. |
|
@csuwildcat LOL! I have a feeling your wording will be better than mine 😅 |
|
Note: do not follow beyond 1 levels deep recursion for |
|
@andorsk made a comment. TODO: add language around using service-profile for dwn spec. |
LiranCohen
force-pushed
the
lirancohen/service-endpoints
branch
from
d2b9f4b to
0ede370
Compare
|
Added the wording regarding recursion. @andorsk Let's create a separate issue for the service-profile so that we can better define what properties can exist in the service profile. Could you also include a link to the service profile spec/docs in that issue? |
TallTed
suggested changes
Apr 16, 2024
|
Can we merge @TallTed 's updates and get this in? |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
Thank you @TallTed !! As always, excellent work! |
andorsk
approved these changes
May 15, 2024
|
Addresses: #284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at aligning the
Service Endpointssections.When looking at this I found myself asking a question which I figured will be good to document here and talk on the call.
Does the
encorsigkey have to reference a key that is associated with the resolvedDID?For example could the JSON example shown have
"sig": ["did:eample:bob#dwn-sig"]?