Fix timestamp defaults in MariaDB 10.2.3 and later #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, MariaDB started outputing 'current_timestamp()' in the default field when DESCRIBE is called on the table. This is a change from 'CURRENT_TIMESTAMP' in mysql and older versions of mariadb. As such, our equality match started to fail and resulting schema dumps produced `current_timestamp()` instead of `\"current_timestamp"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch handles a behaviour change preventing schemas using
DEFAULT current_timestamp()from being correctly imported from MariaDB.MariaDB made a change about five years ago which causes it to say
current_timestamp()rather thancurrent_timestampwhen outputting schema. This was quite deliberate, see https://jira.mariadb.org/browse/MDEV-13377 and MariaDB/server@a411d7fThis builds on @mrenvoize's unmerged #23 .