Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in example XML #153

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

KellyStathis
Copy link
Contributor

Purpose

Fix typo in xml:lang tag for parallel languages example.

Approach

en -> fr for French text

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@KellyStathis
Copy link
Contributor Author

This is a very small change to an example, and I don't think this is example is in any of the test cases. I'm submitting a PR in case I've overlooked something.

@KellyStathis KellyStathis changed the title fix typo fix typo in example XML Jan 22, 2025
@KellyStathis KellyStathis merged commit 7d78e09 into master Jan 23, 2025
1 check passed
@KellyStathis KellyStathis deleted the schema-4.6-20250121-correction branch January 23, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants