Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign northosts - Final adjustments #151

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

danielauener
Copy link
Contributor

Purpose

Final Layout Changes

closes: Add github issue that originated this PR

Approach

  • Logo bigger
  • menu contrast more accessible
  • footer items contrast more accessible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@KellyStathis KellyStathis merged commit e39faa8 into master Nov 15, 2024
1 check passed
@KellyStathis KellyStathis deleted the redesign_northosts branch November 15, 2024 17:32
@KellyStathis KellyStathis restored the redesign_northosts branch November 15, 2024 17:33
@KellyStathis
Copy link
Contributor

Thank you so much for all your work on this @danielauener! Sorry for the delay closing this out on my end.

@KellyStathis KellyStathis deleted the redesign_northosts branch November 15, 2024 17:35
@danielauener
Copy link
Contributor Author

danielauener commented Nov 16, 2024 via email

@KellyStathis
Copy link
Contributor

@danielauener it's up now! 😁 https://schema.datacite.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants