Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: footer signup form loading state #78

Merged
merged 4 commits into from
Apr 3, 2024
Merged

fix: footer signup form loading state #78

merged 4 commits into from
Apr 3, 2024

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Apr 3, 2024 •
edited
Loading

Description

  • footer signup form button doesn't get stuck in loading state
  • adds local cert generation instructions and template .env file to README

Screenshots

Ticket link

Fixes SNGTY-3 (Issue #77)

@tikagan tikagan requested review from orvn and timelytree April 3, 2024 15:49
@tikagan tikagan self-assigned this Apr 3, 2024
timelytree
timelytree approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@timelytree timelytree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked your README entries a little but otherwise it looks great!

@timelytree timelytree merged commit eebec4e into main Apr 3, 2024
2 checks passed
@timelytree timelytree deleted the fix-signup-button-loading branch April 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timelytree timelytree timelytree approved these changes

@orvn orvn Awaiting requested review from orvn

Assignees

@tikagan tikagan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikagan @timelytree