New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny unused deps #1033

Merged

aurexav merged 19 commits into main from bear-deny-unused-dpes

Mar 20, 2023

Member

boundless-forest commented Mar 17, 2023

No description provided.

boundless-forest added 3 commits

March 17, 2023 12:00


          Fix cores

3075dc0


          Fix pallets and precompiles

3c807ce


          Fix runtime

8fa8140

boundless-forest changed the title ~~Deny unused dpes~~ Deny unused deps

github-actions bot assigned boundless-forest

boundless-forest added 6 commits

March 17, 2023 13:47


          Fix benchmark compile 1

83ba215


          Fix test

cce3335


          Fix test 2

45d9d81


          Finish local tests


          Format

14eae39


          Merge branch 'main' into bear-deny-unused-dpes

bbbdfc1

boundless-forest marked this pull request as ready for review

March 17, 2023 07:53

aurexav reviewed

View reviewed changes

core/types/src/lib.rs Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

runtime/common/Cargo.toml Outdated Show resolved Hide resolved

Member

aurexav commented Mar 17, 2023 •

edited

Loading

Please don't update the ecdsa-authority, message-gadget mock and test. I'll update it in the benchmarking PR.

aurexav reviewed

View reviewed changes

node/src/main.rs Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

pallet/deposit/Cargo.toml Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

pallet/staking/Cargo.toml Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

pallet/message-transact/Cargo.toml Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

pallet/message-gadget/src/tests.rs Show resolved Hide resolved

aurexav reviewed

View reviewed changes

runtime/crab/Cargo.toml Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

runtime/darwinia/Cargo.toml Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

runtime/pangolin/Cargo.toml Outdated Show resolved Hide resolved

aurexav reviewed

View reviewed changes

runtime/pangoro/Cargo.toml Outdated Show resolved Hide resolved

github-actions bot commented Mar 17, 2023

Check bbbdfc1 darwinia-dev

Check runtime version

Check runtime storage

github-actions bot commented Mar 17, 2023

Check bbbdfc1 pangolin-dev

Check runtime version

Check runtime storage

github-actions bot commented Mar 17, 2023

Check bbbdfc1 pangoro-dev

Check runtime version

RuntimeVersion {
    spec_name: "Pangoro2",
    impl_name: "DarwiniaOfficialRust",
    authoring_version: 0,
-   spec_version: 6006,
+   spec_version: 6009,
    impl_version: 0,
    transaction_version: 0,
    state_version: 0,
}

Check runtime storage

github-actions bot commented Mar 17, 2023

Check bbbdfc1 crab-dev

Check runtime version

Check runtime storage

Member

aurexav commented Mar 19, 2023

Suggest merging #1038 first.


          Merge branch 'main' into bear-clean

c20a2e3


          Fix reviews

93cd786

boundless-forest commented

View reviewed changes

pallet/message-transact/src/lib.rs Show resolved Hide resolved

boundless-forest marked this pull request as draft

March 20, 2023 01:44

boundless-forest added 2 commits

March 20, 2023 10:07


          Fix benchmark

56a624f


          Fix reviews

4d7a4a6

aurexav reviewed

View reviewed changes

node/src/command.rs Outdated Show resolved Hide resolved


          Fix reviews 2

82f1932

boundless-forest marked this pull request as ready for review

March 20, 2023 02:25


          Minor updates

c6cac02

boundless-forest commented

View reviewed changes

runtime/common/Cargo.toml Show resolved Hide resolved

pallet/ecdsa-authority/Cargo.toml Show resolved Hide resolved


          Delete unused deps

aurexav previously approved these changes

View reviewed changes

aurexav reviewed

View reviewed changes

pallet/ecdsa-authority/Cargo.toml Outdated Show resolved Hide resolved


          Fix review

c8dfe6f

boundless-forest dismissed aurexav’s stale review via

c8dfe6f

March 20, 2023 03:42


          Update

9cf4f1b

aurexav reviewed

View reviewed changes

pallet/ecdsa-authority/Cargo.toml Outdated Show resolved Hide resolved


          Add comma

62d4801

aurexav merged commit 4a03fc8 into main

aurexav deleted the bear-deny-unused-dpes branch

March 20, 2023 03:45

boundless-forest pushed a commit that referenced this pull request


          chore: remove deprecated trait Store for all pallets (#1033)

238294b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet