Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention IsolateNameServer on isolates.md #6338

Closed
wants to merge 1 commit into from

Conversation

mmmeeedddsss
Copy link

I had a use case where I needed to communicate between isolates. The isolate that needs to send a message was not being created by me but created by a library(flutter_local_notification's notification action)

During my search for a solution to create a communication channel in such a case, I found the excerpt that is just above my addition very confusing since it makes me believe that there is no solution to my problem. (Since I cannot interfere with the Isolate.spawn call directly, I thought I cannot obtain a communication channel between the isolates.)

This is why I'm doing that contribution to the doc. In my opinion, it is essential to mention the IsolateNameServer class inside isolates.md file, and state that it can allow dynamical registration of ports even though you cannot control the creation of the isolate.

I am very open for any suggestions and other changes to make that mention more blended to the rest of the document.

Thank you in advance!


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

Copy link

google-cla bot commented Jan 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MaryaBelanger
Copy link
Contributor

/gcbrun

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 17a2d6a):

https://dart-dev--pr6338-main-xm40xvfz.web.app

@ericwindmill ericwindmill added the cl.wont-fix Issue closed as it either can't be or won't be fixed label Jan 22, 2025
@ericwindmill
Copy link
Contributor

Hey @mmmeeedddsss, thanks for the PR.

IsolateNameServer is only available in the context of Flutter, so I'd rather not call it out so prominently in the middle of the Dart isolate docs. Also, there's already a callout to the IsolateNameServer API docs on both the Flutter isolate docs and the Dart concurrency page of the Dart site.

Closing this PR as a no-op.

@mmmeeedddsss
Copy link
Author

@ericwindmill Thank you for your review. I didn't know it is a flutter dependent implementation. Wish you a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl.wont-fix Issue closed as it either can't be or won't be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants