Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements. Migrate to Element2 #3991

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Elements. Migrate to Element2 #3991

merged 3 commits into from
Feb 10, 2025

Conversation

keertip
Copy link
Collaborator

@keertip keertip commented Feb 7, 2025

Migrate to Element 2

  • lib/src/model/annotation.dart
  • lib/src/model/package.dart
  • lib/src/model/package_builder.dart
  • lib/src/model/package_graph.dart

Also removed the ignore_for_file: analyzer_use_new_elements from the generated code.

@keertip keertip requested a review from srawlins February 8, 2025 04:10
srawlins
srawlins approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@keertip keertip merged commit b8c3f02 into dart-lang:main Feb 10, 2025
9 checks passed
@keertip keertip deleted the migrateE branch February 10, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keertip @srawlins