Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MD renderer factory and related markdown renderers. #3599

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

kallentu
Copy link
Member

As title says. Work for #3535.

There's an additional arc of work where I want to just make everything default to HTML renderers and renaming everything and removing the extra interfaces that aren't needed now that the markdown renderers are removed.

That's coming after this though. (I prefer to have smaller segmented CLs.)


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kallentu kallentu requested a review from srawlins December 11, 2023 22:09
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much red!

@kallentu kallentu merged commit 7ac2a1c into main Dec 11, 2023
11 checks passed
@kallentu kallentu deleted the remove-renderer-class branch December 11, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants