Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2976. Add constant expressions tests #3024

Merged
merged 3 commits into from
Jan 9, 2025
Merged

#2976. Add constant expressions tests #3024

merged 3 commits into from
Jan 9, 2025

Conversation

sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of comments!

LanguageFeatures/Static-access-shorthand/constant_expression_A02_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A07_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A08_t01.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A08_t02.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A09_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A09_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A09_t01.dart Outdated Show resolved Hide resolved
sgrekhov
sgrekhov commented Jan 7, 2025
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated. PTAL

LanguageFeatures/Static-access-shorthand/constant_expression_A02_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A07_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A08_t01.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A09_t01.dart Outdated Show resolved Hide resolved
@sgrekhov sgrekhov requested a review from eernstg January 7, 2025 09:09
eernstg
eernstg reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do need to take one more iteration because e! isn't a constant expression.

PS: I'm also still pushing for '.' <identifier>. ;-)

@sgrekhov
Copy link
Contributor Author

sgrekhov commented Jan 8, 2025

e! test is removed, descriptions are updated. PTAL

@sgrekhov sgrekhov requested a review from eernstg January 8, 2025 17:38
eernstg
eernstg approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eernstg eernstg merged commit 044cf88 into dart-lang:master Jan 9, 2025
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 10, 2025
@sgrekhov @athomas
[co19] Roll co19 to 2424cfed7eedf53a122f8bfdbb6319692f726ec8
5862859 
2025-01-10 [email protected] Fixes dart-lang/co19#3039. Fix the new roll failures (dart-lang/co19#3040)
2025-01-10 [email protected] dart-lang/co19#2976. Add constant expressions tests. Part 4. (dart-lang/co19#3037)
2025-01-09 [email protected] dart-lang/co19#2976. Add constant expressions tests (dart-lang/co19#3024)
2025-01-09 [email protected] Fixes dart-lang/co19#3030. Add additional test checking non const in a const constructor initializer list (dart-lang/co19#3036)
2025-01-09 [email protected] dart-lang/co19#2976. Add grammar tests for shorthand with different operators. (dart-lang/co19#3027)
2025-01-08 [email protected] Fixes dart-lang/co19#3028. Add tests for mixin application constant constructor (dart-lang/co19#3032)
2025-01-08 [email protected] dart-lang/co19#2976. Add constant expressions tests.Part 3. (dart-lang/co19#3026)
2025-01-08 [email protected] dart-lang/co19#2976. Add constant expressions tests.Part 2. (dart-lang/co19#3025)
2025-01-06 [email protected] dart-lang/co19#2976. Add more equality tests (dart-lang/co19#3023)
2025-01-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.5.0 to 4.6.0 in the github-actions group (dart-lang/co19#3033)
2024-12-20 [email protected] dart-lang/co19#2976. Add more tests for shorthand equality (dart-lang/co19#3022)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ic8becbc8de5c560f3e9294a47d727442df7c733f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403982
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg