Skip to content

Commit

Permalink
Remove retryStrategy assignments overwritten in ClientFactory::create()
Browse files Browse the repository at this point in the history
  • Loading branch information
danipozo committed Dec 22, 2023
1 parent 3cbd895 commit 2be2486
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion src/Backups/BackupIO_S3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ namespace
client_configuration.connectTimeoutMs = 10 * 1000;
/// Requests in backups can be extremely long, set to one hour
client_configuration.requestTimeoutMs = 60 * 60 * 1000;
client_configuration.retryStrategy = std::make_shared<Aws::Client::DefaultRetryStrategy>(request_settings.retry_attempts);

return S3::ClientFactory::instance().create(
client_configuration,
Expand Down
4 changes: 0 additions & 4 deletions src/Disks/ObjectStorages/S3/diskSettings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ std::unique_ptr<S3::Client> getClient(
HTTPHeaderEntries headers = S3::getHTTPHeaders(config_prefix, config);
S3::ServerSideEncryptionKMSConfig sse_kms_config = S3::getSSEKMSConfig(config_prefix, config);

client_configuration.retryStrategy
= std::make_shared<Aws::Client::DefaultRetryStrategy>(
config.getUInt64(config_prefix + ".retry_attempts", settings.request_settings.retry_attempts));

return S3::ClientFactory::instance().create(
client_configuration,
uri.is_virtual_hosted_style,
Expand Down

0 comments on commit 2be2486

Please sign in to comment.