Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Force user to go through onboarding steps for every registration #4014

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: Force user to go through onboarding steps for every registration #4014

wants to merge 13 commits into from
+96 −20

Conversation

AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented Dec 22, 2024 •
edited
Loading

Changes

This should prevent the user from refreshing to skip the necessary steps. Users created before the given date (currently 08-01-2 5) will not be required to complete the onboarding

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

MI-700 #done

Preview domain

https://mi-700.preview.app.daily.dev

@vercel Vercel
Copy link

vercel bot commented Dec 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 8, 2025 10:20am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 8, 2025 10:20am

@AmarTrebinjac AmarTrebinjac marked this pull request as ready for review December 22, 2024 17:36
@AmarTrebinjac AmarTrebinjac requested a review from a team as a code owner December 22, 2024 17:36
@sshanzel
Copy link
Member

sshanzel commented Jan 3, 2025

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

@AmarTrebinjac
Copy link
Contributor Author

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

@sshanzelI tried creating an user where I skipped tags and settings, then I tried using "useFeedSettings" and both tags and advanced settings is filled with a lot of default stuff. So not sure we can check that way

@sshanzel
Copy link
Member

sshanzel commented Jan 7, 2025 •
edited
Loading

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

@sshanzelI tried creating an user where I skipped tags and settings, then I tried using "useFeedSettings" and both tags and advanced settings is filled with a lot of default stuff. So not sure we can check that way

If you skip the tags part, the followTags will be empty, iirc.

@AmarTrebinjac
Copy link
Contributor Author

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

@sshanzelI tried creating an user where I skipped tags and settings, then I tried using "useFeedSettings" and both tags and advanced settings is filled with a lot of default stuff. So not sure we can check that way

If you skip the tags part, the followTags will be empty, iirc.

For reference to anyone reading, responded to this here

rebelchris
rebelchris reviewed Jan 8, 2025
View reviewed changes
packages/shared/src/hooks/auth/useOnboarding.tsx
Anyone who created an account before this date is exempt from the requirement.
*/
const registeredBeforeRequired =
user?.createdAt && new Date(user.createdAt) < new Date('2025-01-08');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to match exactly release right?

Copy link
Contributor Author

@AmarTrebinjac AmarTrebinjac Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebelchris Not necessarily. If we want to give time for the extension to get published and stuff, we could just set the date a few days in the future. We don't necessarily have to start redirecting users exactly on merge date.

And new extension installs will have to install the newest version, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and do you redirect extension as well?
I'm not sure i'm seeing that part now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in App.tsx are for the extension specifically, while the changes in _app.tsx are for the webapp.

Running pnpm --filter extension dev:chrome and then opening a new tab with a user registered after the given date redirects me to onboarding. Have I missed something? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's fine, maybe we'll need to check with Ido what he thinks on extension vs non extension usage here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of redirecting immediately can we use the "hijacking" page (or whatever it's called) with slightly different copy and on click it redirects to onboarding? I already see the hate of us auto redirecting and users losing focus

rebelchris
rebelchris requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about extension? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoshamun idoshamun idoshamun left review comments

@rebelchris rebelchris rebelchris requested changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmarTrebinjac @sshanzel @rebelchris @idoshamun