feat: pwa install on desktop #3889
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
…install-pwa-desktop
…ydotdev/apps into feat-install-pwa-desktop
…install-pwa-desktop
| import type { BrowserName } from '../../../lib/func'; | ||
| import { getCurrentBrowserName, isPWA } from '../../../lib/func'; | ||
|
|
||
| interface IBeforeInstallPromptEvent extends Event { |
There was a problem hiding this comment.
We never really use the I prefix naming (non trivial but would avoid it moving forward)
There was a problem hiding this comment.
BeforeInstallPromptEvent is the original type name for this so I'm using a different name avoiding future collision. But I'm renaming in order to remove the prefix ✔️
| let installEvent: IBeforeInstallPromptEvent | null = null; | ||
| globalThis?.addEventListener?.( | ||
| 'beforeinstallprompt', | ||
| (e: IBeforeInstallPromptEvent) => { | ||
| e.preventDefault(); | ||
| installEvent = e; | ||
| }, | ||
| { once: true }, | ||
| ); |
There was a problem hiding this comment.
I'm sure you tested it on the browsers that need it, if it works it's fine with me
| isLaptop && | ||
| !isCurrentPWA && | ||
| canUserInstallDesktop && | ||
| activeScreen !== OnboardingStep.InstallDesktop && |
There was a problem hiding this comment.
It's hard to see but doesn't this now prompt it as the first screen?
Also steps beyond this might re-show it now?
There was a problem hiding this comment.
I've tested and this works as intended.
At this point of the function there is no chance to get evaluated before last step ✔️
Changes
onClickNextfor handling skipping specific step;Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Name :
onboarding_desktop_pwaAvailable options:
boolean(true/false)Enrollment for users:
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-install-pwa-desktop.preview.app.daily.dev