-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ParkingMode #6
Conversation
1b60e21
to
6e435d9
Compare
Hi @y3lo, Could you minimize your usage of |
Don't worry, I can wait for you to finish refactoring before rebasing this fork onto the main branch.
Oh indeed. I didn't consider SSR before. The bad news is that I introduced Hope this hasn't caused you additional work. I noticed Emotion has a documentation about its usage of SSR; not sure if that would be helpful. Alternatively, maybe we can explore switching to another CSS-in-JS library that suits us better in the future. Feel free to let me know if you need me to make any changes. |
I pushed most of the changes, it's still a WIP but I didn't want to refactor all the code in 1 stage to reduce the conflicts.
Great, Let Me know which components in the comments when you finish this PR.
No worries, we're still trying to figure out the best approach for css here, I used tailwind because it's faster in development speed and we can override the styles easily in the App repo, but we may have to introduce a prefix for tw, because some of the old pages use a different configuration in tailwind.
Next.js is still working on supporting emotion 😂, I guess choosing styled-jsx could work well with Next.JS, or maybe when stylex is stable, we could change the emotion code to stylex. |
8004851
to
fb1fde2
Compare
- NameDisplay - Statistic - ScrollDownTip - usePrettyPrice - useShortAddress
- @emotion/css - @emotion/styled - punycode - marked - dompurify
Changes
New Components and hooks
Add peer dependencies:
Notice
According to the design of the ParkingMode page, breakpoints were added to components in this PR for responsiveness, but in order to prevent affecting other branches, existing components were not handled yet.
This page involves TLD buttons, but I think reorganizing the button components first could be more efficient for it. Therefore, this PR does not handle styles related to TLD buttons also.