Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(runners): bump macos gh actions runner version #506

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Feb 2, 2025

Description

This PR bumps the version of MacOS used by GH Actions runners as macos-13 is no longer macos-latest (instead, latest is now macos-14). This also provides us the capability of testing with ARM-based architectures which could be important to understand when it comes to functionality of Pycytominer.

Should be merged after #505

Closes #501

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (bf375ba) to head (58e4920).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          57       57           
  Lines        3188     3188           
=======================================
  Hits         3011     3011           
  Misses        177      177           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d33bs d33bs marked this pull request as ready for review February 2, 2025 22:54
@d33bs d33bs requested review from gwaybio and kenibrewer February 3, 2025 14:37
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might run into some merge conflicts with #507 , FYI

@d33bs
Copy link
Member Author

d33bs commented Feb 4, 2025

Weird bug popped up with MacOS Py 3.11 after updating dependencies. Appears to have something to do with Numpy and Pandas dependencies and unhappiness with the venv.

@d33bs
Copy link
Member Author

d33bs commented Feb 4, 2025

Seeking to resolve failing job in #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump GitHub Actions tests to use macos-14
3 participants