-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Parsl app concurrency with futures #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First time I've started looking at the parsl stuff in this repo, so apologies if some of these questions don't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the explanations!
Thank you @kenibrewer ! Merging this in. |
Description
This PR addresses an issue with Parsl app evaluation to enable concurrency throughout
_to_parquet()
and related. It stems from investigation through #192, originally inspired by work towards documenting #176 (after finding no significant differences in Parsl configurations performance). After making these changesmypy
was upset about a few type hints, so I updated these as well to ensure pre-commit checks could pass.Generally, this work focused on following the patterns mentioned under Parsl documentation on using
Futures
.Closes #192
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.