bug fix and cargo

.github/workflows/release.yml

@@ -45,7 +45,7 @@ on:
 jobs:
   # Run 'cargo dist plan' (or host) to determine what tasks we need to do
   plan:
-    runs-on: "ubuntu-20.04"
+    runs-on: "ubuntu-latest"
     outputs:
       val: ${{ steps.plan.outputs.manifest }}
       tag: ${{ !github.event.pull_request && github.ref_name || '' }}
@@ -158,7 +158,7 @@ jobs:
     needs:
       - plan
       - build-local-artifacts
-    runs-on: "ubuntu-20.04"
+    runs-on: "ubuntu-latest"
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       BUILD_MANIFEST_NAME: target/distrib/global-dist-manifest.json
@@ -208,7 +208,7 @@ jobs:
     if: ${{ always() && needs.plan.outputs.publishing == 'true' && (needs.build-global-artifacts.result == 'skipped' || needs.build-global-artifacts.result == 'success') && (needs.build-local-artifacts.result == 'skipped' || needs.build-local-artifacts.result == 'success') }}
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    runs-on: "ubuntu-20.04"
+    runs-on: "ubuntu-latest"
     outputs:
       val: ${{ steps.host.outputs.manifest }}
     steps:
@@ -272,7 +272,7 @@ jobs:
     # still allowing individual publish jobs to skip themselves (for prereleases).
     # "host" however must run to completion, no skipping allowed!
     if: ${{ always() && needs.host.result == 'success' }}
-    runs-on: "ubuntu-20.04"
+    runs-on: "ubuntu-latest"
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:

Cargo.toml

@@ -13,6 +13,7 @@ resolver = "2"
 edition = "2021"
 license = "MIT"
 authors = ["Cycle Five <[email protected]>"]
+allow-dirty = true
 
 [workspace.dependencies.sqlx]
 version = "0.7.4"

crack-core/src/messaging/interface.rs

@@ -290,18 +290,12 @@ pub fn build_now_playing_embed_metadata(
         .footer(CreateEmbedFooter::new(footer_text).icon_url(footer_icon_url))
 }
 
-// pub async fn track_handle_to_metadata(
-//     track: &TrackHandle,
-// ) -> Result<(Option<UserId>, Option<Duration>, MyAuxMetadata), CrackedError> {
-//     Ok((requesting_user, duration, MyAuxMetadata(metadata)))
-// }
-
 /// Creates a now playing embed for the given track.
 pub async fn create_now_playing_embed(track: &TrackHandle) -> CreateEmbed {
     // let (requesting_user, duration, metadata) = track_handle_to_metadata(track).await.unwrap();
     let metadata = get_track_handle_metadata(track).await;
     let requesting_user = get_requesting_user(track).await.ok();
-    let duration = Some(track.get_info().await.unwrap().position);
+    let duration = Some(track.get_info().await.unwrap_or_default().position);
     build_now_playing_embed_metadata(requesting_user, duration, MyAuxMetadata(metadata))
 }
 

dist-workspace.toml

@@ -3,6 +3,7 @@ members = ["cargo:crack-cli"]
 
 # Config for 'cargo dist'
 [dist]
+allow-dirty = ["ci"]
 # The preferred cargo-dist version to use in CI (Cargo.toml SemVer syntax)
 cargo-dist-version = "0.21.0"
 # CI backends to support
@@ -19,9 +20,9 @@ install-updater = false
 hosting = "github"
 custom-success-message = "Be of Mæth and malinger not with Commies!"
 # Run on latest ubuntu
-[package.metadata.dist.github-custom-runners]
+[dist.github-custom-runners]
 x86_64-unknown-linux-gnu = "ubuntu-latest"
 
-[[package.metadata.dist.extra-artifacts]]
+[[dist.extra-artifacts]]
 artifacts = ["data.tar"]
 build = ["tar", "-cf", "data.tar", "data"]