trurl: on strdup() failures, exit immediately #324

bagder · 2024-08-16T09:27:51Z

Rather than continuing and acting weirdly.

emanuele6 · 2024-08-16T09:33:17Z

How about a estrdup() wrapper that errors when strdup() returns NULL since we always use the same error message?

bagder · 2024-08-16T09:37:18Z

I'll get it done!

Add an xstrdup() version for this purpose. Rather than continuing and acting weirdly.

bagder · 2024-08-16T15:10:15Z

I went with xstrdup() since it seems to be common to use the x prefix for xmalloc() etc for the same general purpose.

emanuele6 · 2024-08-16T16:40:30Z

I suggested estrdup because it and other e* function are standard in BSD (util.h) and I am familiar with them https://man.netbsd.org/NetBSD-10.0/emalloc.3

But I have also seen x* used with the same meaning in the source code of bash.

bagder force-pushed the bagder/strdup-fails branch 2 times, most recently from e8b2481 to 16140cf Compare August 16, 2024 11:41

trurl: on strdup() failures, exit immediately

3ef3b15

Add an xstrdup() version for this purpose. Rather than continuing and acting weirdly.

bagder force-pushed the bagder/strdup-fails branch from 16140cf to 3ef3b15 Compare August 16, 2024 15:09

bagder merged commit 53d9998 into master Aug 16, 2024
11 checks passed

bagder deleted the bagder/strdup-fails branch August 16, 2024 21:29

Provide feedback