Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use in-process language server #105

Merged
merged 7 commits into from
Sep 13, 2022
Merged

Use in-process language server #105

merged 7 commits into from
Sep 13, 2022

Conversation

aslakhellesoy
Copy link
Contributor

🤔 What's changed?

The language server is instantiated in the VSCode extension

⚡️ What's your motivation?

See cucumber/language-server#65

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Can anyone see any problems with this approach?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@aslakhellesoy aslakhellesoy merged commit 38e3544 into main Sep 13, 2022
@aslakhellesoy aslakhellesoy deleted the in-process-language-server branch September 13, 2022 10:53
@kieran-ryan kieran-ryan added the 🏦 debt Tech debt label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏦 debt Tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslakhellesoy @kieran-ryan