Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency cucumber_messages to v19 - autoclosed #6

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 8, 2022

Mend Renovate

This PR contains the following updates:

Package Update Change
cucumber_messages major ~> 15.0 -> ~> 19.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the 🤖 dependencies Dependency upgrade label Nov 8, 2022
@renovate renovate bot force-pushed the renovate/cucumber_messages-19.x branch from f8320b6 to 379bab8 Compare November 8, 2022 15:11
@mpkorstanje
Copy link
Contributor

@WannesFransen1994 could you please have a look at this?

@renovate renovate bot force-pushed the renovate/cucumber_messages-19.x branch from 379bab8 to e399b2b Compare November 8, 2022 18:17
@WannesFransen1994
Copy link
Contributor

I'll take a look at it this evening!

@renovate renovate bot force-pushed the renovate/cucumber_messages-19.x branch 2 times, most recently from 09a979f to 137b321 Compare November 9, 2022 14:36
@mpkorstanje
Copy link
Contributor

Cheers! Appreciated!

@renovate renovate bot force-pushed the renovate/cucumber_messages-19.x branch from 137b321 to f71153a Compare November 9, 2022 15:55
@WannesFransen1994
Copy link
Contributor

It seems that with the new releases of messages, something went wrong with the Elixir release since the generated/compiled files aren't included in this release. (Current messages version is still generating the files based on protox, but aren't included in the published package)

Since the new messages version (based on the json schemas) won't be compatible with this gherkin version, i'd suggest keeping the old messages version for now. Then when the new messages version (cucumber/messages#29) is released correctly, we can correct the current gherkin implementation to the latest messages?

Unless I can do something else to make this process "smoother", I'll leave it to you @mpkorstanje . Sadly i'm not so familiar with the current release process with the polyglot repository (nor am i sure that I should be the one doing that), but let me know if I can do anything else!

@mpkorstanje
Copy link
Contributor

Unfortunately @aurelien-reeves is no longer working for SmartBear and because of that no longer contributing to Cucumber. Now I do not know why cucumber/messages#29 wasn't merged. Perhaps because cucumber/messages#29 (review) hasn't been answered.

If you could get that PR into a merge-able state (I'll leave the exact definition of that up to you) then I can see it merged and released.

@mpkorstanje
Copy link
Contributor

The new release process is linked to from RELEASING.md and can be found here: https://github.com/cucumber/.github/blob/main/RELEASING.md. The process is really light weight and takes about 10 seconds to perform.

TL;DR: Anyone who can push to main can prepare a release, only a few people can perform the release.

@renovate renovate bot force-pushed the renovate/cucumber_messages-19.x branch from f71153a to 94eecab Compare November 10, 2022 12:37
@WannesFransen1994
Copy link
Contributor

Thank you for the info. I'll make the branch merge-able this weekend and if there are any uncertainties, I'll mention it on the next weekly meeting (or ask it on the PR comments).

@mpkorstanje
Copy link
Contributor

Cheers, and no rush!

@renovate renovate bot force-pushed the renovate/cucumber_messages-19.x branch 3 times, most recently from 19fd486 to c3a9f6b Compare November 13, 2022 19:26
@renovate renovate bot force-pushed the renovate/cucumber_messages-19.x branch from c3a9f6b to e4c31b0 Compare November 13, 2022 21:44
@renovate renovate bot changed the title chore(deps): update dependency cucumber_messages to v19 chore(deps): update dependency cucumber_messages to v19 - autoclosed Nov 14, 2022
@renovate renovate bot closed this Nov 14, 2022
@renovate renovate bot deleted the renovate/cucumber_messages-19.x branch November 14, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 dependencies Dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants