-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency cucumber_messages to v19 - autoclosed #6
Conversation
f8320b6
to
379bab8
Compare
@WannesFransen1994 could you please have a look at this? |
379bab8
to
e399b2b
Compare
I'll take a look at it this evening! |
09a979f
to
137b321
Compare
Cheers! Appreciated! |
137b321
to
f71153a
Compare
It seems that with the new releases of messages, something went wrong with the Elixir release since the generated/compiled files aren't included in this release. (Current messages version is still generating the files based on protox, but aren't included in the published package) Since the new messages version (based on the json schemas) won't be compatible with this gherkin version, i'd suggest keeping the old messages version for now. Then when the new messages version (cucumber/messages#29) is released correctly, we can correct the current gherkin implementation to the latest messages? Unless I can do something else to make this process "smoother", I'll leave it to you @mpkorstanje . Sadly i'm not so familiar with the current release process with the polyglot repository (nor am i sure that I should be the one doing that), but let me know if I can do anything else! |
Unfortunately @aurelien-reeves is no longer working for SmartBear and because of that no longer contributing to Cucumber. Now I do not know why cucumber/messages#29 wasn't merged. Perhaps because cucumber/messages#29 (review) hasn't been answered. If you could get that PR into a merge-able state (I'll leave the exact definition of that up to you) then I can see it merged and released. |
The new release process is linked to from TL;DR: Anyone who can push to main can prepare a release, only a few people can perform the release. |
f71153a
to
94eecab
Compare
Thank you for the info. I'll make the branch merge-able this weekend and if there are any uncertainties, I'll mention it on the next weekly meeting (or ask it on the PR comments). |
Cheers, and no rush! |
19fd486
to
c3a9f6b
Compare
c3a9f6b
to
e4c31b0
Compare
This PR contains the following updates:
~> 15.0
->~> 19.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.