Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the AST in the JavaScript implementation #109

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

aslakhellesoy
Copy link
Contributor

🤔 What's changed?

The Cucumber Expression AST is exposed via CucumberExpression.ast. The AST types are exported.

⚡️ What's your motivation?

Having access to the AST is required to fix cucumber/language-service#16 and possibly also #51

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

By doing this we're exposing the public API surface. If #41 ever gets implemented, it may require a change to the AST. We can live with that.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@aslakhellesoy aslakhellesoy mentioned this pull request Apr 21, 2022
@aslakhellesoy aslakhellesoy merged commit 0c9b826 into main Apr 21, 2022
@aslakhellesoy aslakhellesoy deleted the javascript-expose-ast branch April 21, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create step documents from steps even if there are no matching step definitions
1 participant