Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd: set PKG_CONFIG_PATH in Dockerfile #1385

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

pdmorrow
Copy link
Contributor

PKG_CONFIG_PATH is not set in the FreeBSD Dockerfile which means crates which have an external system dependency cannot find those dependencies to link against.

Closes #1384

PKG_CONFIG_PATH is not set in the FreeBSD Dockerfile which means
crates which have an external system dependency cannot find those
dependencies to link against.

Closes cross-rs#1384
@pdmorrow pdmorrow requested a review from a team as a code owner December 14, 2023 14:48
@Emilgardis Emilgardis added no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect any cross-compilation targets. labels Dec 14, 2023
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Emilgardis Emilgardis removed the no changelog A valid PR without changelog (no-changelog) label Dec 14, 2023
@Emilgardis Emilgardis added this pull request to the merge queue Dec 14, 2023
@pdmorrow
Copy link
Contributor Author

Thanks!

Thanks for the quick review!

Merged via the queue into cross-rs:main with commit bfc59f0 Dec 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeBSD: Docker image doesn't set PKG_CONFIG_PATH
2 participants