Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pt 2136 progress bar does not trigger any screen reader status #16398

Open
wants to merge 16 commits into
base: 5.6
Choose a base branch
from

Conversation

gcamacho079
Copy link
Contributor

Description

This PR:

  • Introduces a new IntervalManager class that can be used for managing JavaScript intervals. Includes methods for starting and stopping the interval.
  • The ProgressBar has been updated so that announcements are made via an IntervalManager instance. This allows screen reader users to get intermittent updates via the Craft.cp.announce() method. This functionality can be disabled by setting announceProgress to false via the settings if live region updates will be handled elsewhere in the code.

To test:

  • Go to a page where a progress bar is loaded (for example, Asset Indexes or Caches)
  • Start a task that triggers the progress bar
  • Use a screen reader (or an extension like NerdeRegion that visualizes the live region updates) to verify that progress is intermittently announced

Related issues

Resolves PT-2136

@gcamacho079 gcamacho079 added enhancement improvements to existing features accessibility 👤 features related to accessibility labels Jan 7, 2025
Copy link

linear bot commented Jan 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility enhancement improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants