Expanded handling for protein strings #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PIP 10 has a different module structure, two import calls fail. This change fixes it, while stitll maintaining compatibility with PIP 9 or earlier.
Fix install error when PIP 10 is installed
jtratner
pushed a commit
that referenced
this pull request
Nov 20, 2019
Remove kwarg from ValueError
|
@jeargle Sorry for the extremely long delay in looking at this. Can you resolve the merge conflicts here and add your example HGVS strings as test cases in this test section. After that, can take a final pass at this and should be able to get it merged and a new version released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just a couple of small changes so that more protein HGVS strings can be parsed. I added 1-letter amino acid codes (including '*' for termination) and termination codes for frameshifts.
example HGVS strings:
p.R97G
p.Arg97Glyfs26
p.Arg97GlyfsTer26
p.R97Gfs26
p.R97GfsTer26