Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore and ignore HTTP links #2186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

godylockz
Copy link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactoring and improving code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Description

Git Ignore Additions - Add cache/obsidian
Ignore HTTP links during building

Additional context

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore has different configurations in different environments. Currently, this project does not have the files you listed.

If html-proofer does not enforce HTTPS, it will compromise the security of network transmission because the output page contains HTTP links.

@godylockz
Copy link
Author

Figured I'd suggest these changes just in case I'm not the only one in the community with this type of configuration.

.gitignore has different configurations in different environments. Currently, this project does not have the files you listed.

Obsidian is a popular markdown editor. If I open the folder as a vault, would want to ignore it from commit history as it changes every time the vault is opened.

If html-proofer does not enforce HTTPS, it will compromise the security of network transmission because the output page contains HTTP links.

Modern browsers default HTTPS when available. If I'm making a blog post with a http link, for instance if the target URL is only available on port 80 or another port then the proofer needs to be setup for ignoring or it won't build.

@cotes2020
Copy link
Owner

I understand your motivation, but ultimately most of the modifications are specific to your use case. Although I do not use Obsidian , it is acceptable to add its hidden folder to .gitignore. However, please keep the other modifications in your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants