Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): ignore codecov tests from wait-for-status-checks #1292

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Jan 22, 2025

Looks like poseidon/wait-for-status-checks is not working well with codecov. They are passing but initially, they might be marked as failed and wait-for-status-checks finds that value.
If we really want to make also codecov required, I think we can just set them individually alongside wait-for-status-checks

Failed run: https://github.com/corazawaf/coraza/actions/runs/12911960264/job/36006081732

Run poseidon/[email protected]
Starting polling GitHub Check runs...
timeout: 3600 seconds
interval: 10 seconds
ignore: ["","enforce-all-checks"]
Fetching check runs for corazawaf/coraza@6f9d99048e9a8039a18ce194b42764483f9ed9a2
Parse 71 check runs
One or more watched check runs were not successful
> check run "codecov/patch" is completed with conclusion "failure" (unsuccessful)
> check run "codecov/project" is completed with conclusion "failure" (unsuccessful)
Error: One or more check runs were not successful

@M4tteoP M4tteoP requested a review from a team as a code owner January 22, 2025 22:48
@M4tteoP M4tteoP changed the title Poseidon fix(ci): ignore codecov tests from wait-for-status-checks Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (1b1c642) to head (9e4a341).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1292   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         169      169           
  Lines        9770     9770           
=======================================
  Hits         7988     7988           
  Misses       1533     1533           
  Partials      249      249           
Flag Coverage Δ
coraza.rule.case_sensitive_args_keys 81.71% <ø> (ø)
coraza.rule.multiphase_valuation 81.76% <ø> (ø)
coraza.rule.no_regex_multiline 81.69% <ø> (ø)
default 81.76% <ø> (ø)
examples+ 16.54% <ø> (ø)
examples+coraza.rule.case_sensitive_args_keys 81.71% <ø> (ø)
examples+coraza.rule.multiphase_valuation 81.59% <ø> (ø)
examples+coraza.rule.no_regex_multiline 81.61% <ø> (ø)
examples+memoize_builders 81.71% <ø> (ø)
examples+no_fs_access 81.04% <ø> (ø)
ftw 81.76% <ø> (ø)
memoize_builders 81.85% <ø> (ø)
no_fs_access 81.20% <ø> (ø)
tinygo 81.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant