Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix avm tests #3549

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

acheroncrypto
Copy link
Collaborator

Problem

Reusable tests workflow runs avm tests twice, which sometimes causes the CI to fail due to GitHub rate-limits.

- run: cargo fmt -- --check
- run: cargo clippy --all-targets -- -D warnings
- run: cargo test
# using singlethreaded testing for avm so that tests that change files do not conflict with each other
- run: cd avm && cargo fmt -- --check && cargo clippy --all-targets -- -D warnings && cargo test -- --test-threads=1

As the comment suggests, this doesn't seem to be intent of the initial author.

Summary of changes

Exclude avm from the initial cargo test command, and run avm as single-threaded separately afterwards.

Additionally, remove the redundant formatting (cargo fmt) and linting (cargo clippy) commands specific to avm, since the initial runs already take care of this process.

Copy link

vercel bot commented Feb 10, 2025

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added ci fix Bug fix PR labels Feb 10, 2025
@acheroncrypto acheroncrypto merged commit fa38102 into coral-xyz:master Feb 10, 2025
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci fix Bug fix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant