-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containers.conf: Set a different default ip subnet for qm containers #743
Conversation
Reviewer's Guide by SourceryThis pull request modifies the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Otherwise both host and qm containers have the same range and things get confused. Signed-off-by: Alexander Larsson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alexlarsson - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be helpful to add a comment explaining why 10.89.0.0/16 was chosen as the new subnet.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
48d2ec4
to
38374ff
Compare
Otherwise both host and qm containers have the same range and things get confused.
resolve #714
Summary by Sourcery
Enhancements: