Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selinux: Allow qm_t to mmap qm_file_t char devices #742

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

alexlarsson
Copy link
Collaborator

@alexlarsson alexlarsson commented Mar 3, 2025

This allows qm apps to mmap /dev/zero which is a common operation, and should be safe.

Fixes: #741

Summary by Sourcery

Bug Fixes:

  • Fixes issue where qm apps could not mmap /dev/zero.

Copy link

sourcery-ai bot commented Mar 3, 2025

Reviewer's Guide by Sourcery

This pull request adds a rule to the SELinux policy that allows processes running in the qm_t domain to map character devices labeled with the qm_file_t type into their address space. This is done to allow qm applications to mmap /dev/zero.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Allowed the qm_t domain to map character devices labeled with qm_file_t into its address space.
  • Added a rule allowing qm_t to mmap character devices labeled with qm_file_t.
qm.if

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alexlarsson - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you add a comment to the code explaining why this change is considered safe?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows qm apps to mmap /dev/zero which is a common operation, and
should be safe.

Fixes: #741
Signed-off-by: Alexander Larsson <[email protected]>
@alexlarsson alexlarsson force-pushed the fix-qm-selinux-mmap-dev-zero branch from 2d8dd15 to 05cfa40 Compare March 4, 2025 08:12
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yarboa Yarboa merged commit 6e15f6c into main Mar 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selinux: Allow apps to mmap /dev/zero
2 participants