qm.spec: Fix packaing for other selinux policies

[alexlarsson]

The current package hardcodes that post-install it will install the module to the "targeted" policy (but the macro only does this is it is also the active policy). This means if the active policy is something else, such as "automotive", then the qm module is not installed at all, and qm doesn't work.

We fix this by always installing the module to the active selinux policy. This is how e.g. container-selinux does it.

In addition we remove the hard post-require on selinux-policy-target and replace it with selinux-policy-any, which all selinux policy packages provide. We also add a recommendataion of selinux-policy-targeted, so most people get it. This is also what container-selinux does.

Fixes #730

Summary by Sourcery

Fixes an issue where the qm module was not installed when the active SELinux policy was not 'targeted' by ensuring the module is installed to the active SELinux policy. Also updates the package dependencies to use selinux-policy-any instead of selinux-policy-targeted.

Bug Fixes:

• Fixes an issue where the qm module was not installed when the active SELinux policy was not 'targeted'.

Build:

• Replaces the hard post-require on selinux-policy-target with selinux-policy-any, which all SELinux policy packages provide.
• Adds a recommendation for selinux-policy-targeted to ensure most users get it.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the rpm spec file to correctly install the selinux module for qm, even when the active selinux policy is not 'targeted'. It achieves this by installing the module to the active selinux policy and updating the package dependencies.

Sequence diagram for SELinux module installation

sequenceDiagram
    participant RPM Package Manager
    participant SELinux Policy
    RPM Package Manager->>SELinux Policy: Installs qm module to active policy
    activate SELinux Policy
    SELinux Policy-->>RPM Package Manager: Acknowledges installation
    deactivate SELinux Policy

Loading

File-Level Changes

Change	Details	Files
Modified the SELinux policy handling to install modules to the active policy and updated dependencies.	Replaced the hardcoded selinuxtype with a dynamic check against the active SELinux policy. Replaced the hard post-require on selinux-policy-targeted with selinux-policy-any and added a recommendation for selinux-policy-targeted.	rpm/qm.spec

Possibly linked issues

• Selinux policy in QM rpm only works with the targeted policy #730: The PR fixes the issue by always installing the module to the active SELinux policy and removing the hard dependency on the targeted policy.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @alexlarsson - I've reviewed your changes - here's some feedback:

Overall Comments:

• It might be good to add a comment explaining why we are sourcing the selinux config file in the post scripts.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}