Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/get images digests and repositories #174

Merged

Conversation

eesprit
Copy link
Contributor

@eesprit eesprit commented Jan 31, 2024

This Pull Request adds a new label on the podman_image_info metric : the sha256 Digest of the image

This is a more secure way to distinguish image when the tag might be overwritten.

With the digest, it is possible to identify the image in a registry even if the tag has been reused on a new image.

@navidys
Copy link
Collaborator

navidys commented Jan 31, 2024

Hi @eesprit

Thanks for the PR.

DCO check failed, I would appreciate it if you can sign your commits and also update README.md metrics output examples.

@eesprit eesprit force-pushed the feature/get_images_digests_and_repositories branch from 550c6dc to 99f5636 Compare February 1, 2024 08:55
@eesprit
Copy link
Contributor Author

eesprit commented Feb 1, 2024

Hi @navidys

Thanks for four feedback.

I updated the README with some examples, and added the missing signoff on commits.

@navidys
Copy link
Collaborator

navidys commented Feb 1, 2024

LGTM

@navidys navidys merged commit 68bbd64 into containers:main Feb 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants