Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpoint filename #353

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix checkpoint filename #353

merged 1 commit into from
Jan 23, 2025

Conversation

hanwen
Copy link

@hanwen hanwen commented Dec 4, 2024

On podman 5.2.5, the checkpoint archive is a zstd compressed tar file.

@rhatdan
Copy link
Member

rhatdan commented Jan 22, 2025

@hanwen Thanks, Please sign your PR?
@adrianreber PTAL

@adrianreber
Copy link

@hanwen do you know when that changed?

@hanwen
Copy link
Author

hanwen commented Jan 22, 2025

commit 8aa5340ade611bf3bce3c8613efce28f2b174a1b
Author: Adrian Reber <[email protected]>
Date:   Fri Jun 4 13:45:33 2021 +0000

    Add parameter to specify checkpoint archive compression
...
    This also changes the default from `gzip` to `zstd`. This change should
    not break anything as the restore code path automatically handles
    whatever compression the user provides during restore.


hanwen@hanwen-flow:~/vc/containers/podman$ git describe --contains 8aa5340ade
v3.3.0-rc1~201^2~2

@adrianreber
Copy link

Ah, that was me 😉

LGTM (but needs to be signed-off-by).

As of commit 8aa5340ade61 ("Add parameter to specify checkpoint
archive compression", Jun 4 2021) the checkpoint archive is a zstd
compressed tar file by default.

Signed-off-by: Han-Wen Nienhuys <[email protected]>
@hanwen-flow
Copy link
Contributor

PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 merged commit ba83cd5 into containers:main Jan 23, 2025
3 checks passed
@Luap99
Copy link
Member

Luap99 commented Jan 23, 2025

Looks like the podman-container-checkpoint man page also is wrong there if you like to fix there too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants