Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uppercase mount attributes #487

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

D3vil0p3r
Copy link
Contributor

Fix #486

@rhatdan
Copy link
Member

rhatdan commented Dec 19, 2024

/approve
LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 19, 2024

@jwhonce @umohnani8 PTAL

@jwhonce jwhonce requested a review from inknos January 7, 2025 03:12
@jwhonce
Copy link
Member

jwhonce commented Jan 7, 2025

@D3vil0p3r Thank you for your PR! Code looks good. I would love to see a unit test. Thanks.

@D3vil0p3r
Copy link
Contributor Author

D3vil0p3r commented Jan 7, 2025

@D3vil0p3r Thank you for your PR! Code looks good. I would love to see a unit test. Thanks.

You are so kind. I added also a test. For consistency, I added it in test_container_create.py file, inside def test_container_mounts() function. It can be run on directory integration by executing:

pytest test_container_create.py::ContainersIntegrationTest::test_container_mounts

Please, can you review it?

@umohnani8
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3vil0p3r, rhatdan, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e79f4af into containers:main Jan 7, 2025
16 checks passed
@D3vil0p3r D3vil0p3r deleted the patch-2 branch January 7, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Uppercase mount attributes to be compliant with Docker Py
4 participants