Create OCI image manifest #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaideep Rao <[email protected]>
jaideepr97
force-pushed
the
create-manifest
branch
from
f115d6a to
326ab95
Compare
jaideepr97
force-pushed
the
create-manifest
branch
3 times, most recently
from
60826ae to
21b54f1
Compare
Signed-off-by: Jaideep Rao <[email protected]>
jaideepr97
force-pushed
the
create-manifest
branch
from
21b54f1 to
b4ba3ea
Compare
tarilabs
approved these changes
Jan 22, 2025
Comment on lines
+163
to
+176
| def get_file_media_type(file_path: os.PathLike) -> str: | ||
| """ | ||
| Get the MIME type of a file using the `file` command. | ||
| """ | ||
| try: | ||
| result = subprocess.run(['file', '--mime-type', '-b', file_path], stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=True) | ||
| mime_type = result.stdout.decode('utf-8').strip() | ||
| return mime_type | ||
| except subprocess.CalledProcessError as e: | ||
| print(f"Error occurred while getting MIME type: {e}") | ||
| return MIMETypes.octet_stream | ||
| except Exception as e: | ||
| print(f"Unexpected error: {e}") | ||
| return MIMETypes.octet_stream |
Comment on lines
37
to
59
| def create_blobs(source_dir: Path, oci_dir: Path): | ||
| if not source_dir.exists(): | ||
| raise ValueError(f"Input directory '{source_dir}' does not exist.") | ||
|
|
||
| sha256_path = oci_dir / "blobs" / "sha256" | ||
| os.makedirs(sha256_path, exist_ok=True) | ||
|
|
||
| layers = {} # layer digest : diff_id | ||
|
|
||
| # assume flat structure for source_dir for now | ||
| # TODO: handle subdirectories appropriately | ||
| model_files = [source_dir / Path(f) for f in os.listdir(source_dir) if os.path.isfile(os.path.join(source_dir, f))] | ||
|
|
||
| for model_file in model_files: | ||
|
|
||
| # handle model card file if encountered - assume README.md is the modelcard | ||
| if os.path.basename(os.path.normpath(model_file)).endswith("README.md"): | ||
| postcomp_chksum, precomp_chksum = targz_from_file(model_file, sha256_path) | ||
| layers[postcomp_chksum] = precomp_chksum | ||
| else: | ||
| checksum = tarball_from_file(model_file, sha256_path) | ||
| layers[checksum] = checksum | ||
| return layers |
There was a problem hiding this comment.
|
in hope of making it easier, going to exceptionally merge-commit for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to create an OCI image manifest and write it out to the blobs dir for a provided source model directory
should be merged after #7