Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option 'remove' to remove original content files #17

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

tarilabs
Copy link
Member

add option 'remove' to remove original content files after having stored them in blob layers

cc @Crazyglue

@tarilabs tarilabs requested a review from jaideepr97 February 19, 2025 11:17
Copy link
Contributor

@Crazyglue Crazyglue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just a tiny nit

olot/cli.py Outdated

from .basics import oci_layers_on_top


@click.command()
@click.argument('ocilayout', type=click.Path(exists=True, file_okay=False, dir_okay=True))
@click.argument('model_files', nargs=-1)
def cli(ocilayout: str, model_files):
oci_layers_on_top(Path(ocilayout), model_files)
@click.option('-r', '--remove', is_flag=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe --remove-originals or --remove-original-files is more intuitive?

Signed-off-by: tarilabs <[email protected]>
Signed-off-by: tarilabs <[email protected]>
after having stored them in blob layers

Signed-off-by: tarilabs <[email protected]>
@tarilabs tarilabs force-pushed the tarilabs-20250219-removeOriginals branch from 56cacac to ec9c3ad Compare February 20, 2025 10:00
@tarilabs tarilabs merged commit 1495aaa into main Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants