-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option 'remove' to remove original content files #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just a tiny nit
olot/cli.py
Outdated
|
||
from .basics import oci_layers_on_top | ||
|
||
|
||
@click.command() | ||
@click.argument('ocilayout', type=click.Path(exists=True, file_okay=False, dir_okay=True)) | ||
@click.argument('model_files', nargs=-1) | ||
def cli(ocilayout: str, model_files): | ||
oci_layers_on_top(Path(ocilayout), model_files) | ||
@click.option('-r', '--remove', is_flag=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe --remove-originals
or --remove-original-files
is more intuitive?
Signed-off-by: tarilabs <[email protected]>
Signed-off-by: tarilabs <[email protected]>
after having stored them in blob layers Signed-off-by: tarilabs <[email protected]>
Signed-off-by: tarilabs <[email protected]>
56cacac
to
ec9c3ad
Compare
add option 'remove' to remove original content files after having stored them in blob layers
cc @Crazyglue