core: cli modelcard option, E2E test refactor #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tarilabs
commented
Feb 18, 2025
tarilabs
commented
- cli option for ModelCarD
- refactor E2E test based on local testing, now checking we can 'pin' this in GHA with this PR
|
cc @Crazyglue |
tarilabs
force-pushed
the
tarilabs-20250218-modelcardannotations
branch
from
8b8ad1c to
565f977
Compare
Signed-off-by: tarilabs <[email protected]>
tarilabs
force-pushed
the
tarilabs-20250218-modelcardannotations
branch
from
565f977 to
9c2c96d
Compare
Crazyglue
approved these changes
Feb 18, 2025
.github/workflows/e2e.yaml
Outdated
Comment on lines
47
to
60
| - name: Run OLOT tutorial of README, and load image in KinD for amd64 | ||
| run: | | ||
| IMAGE_DIR=download | ||
| OCI_REGISTRY_SOURCE=quay.io/mmortari/hello-world-wait:latest | ||
| OCI_REGISTRY_DESTINATION=localhost:5001/nstestorg/modelcar | ||
| rm -rf $IMAGE_DIR | ||
| skopeo copy --multi-arch all docker://${OCI_REGISTRY_SOURCE} oci:${IMAGE_DIR}:latest | ||
| poetry run olot $IMAGE_DIR tests/data/sample-model/model.joblib --modelcard tests/data/sample-model/README.md | ||
| # copy modelcar from oci-layout to the local docker registry | ||
| skopeo copy --tls-verify=false --multi-arch all oci:${IMAGE_DIR}:latest docker://${OCI_REGISTRY_DESTINATION} | ||
| # make sure the annotation is present | ||
| digest=$(skopeo inspect --tls-verify=false --raw docker://localhost:5001/nstestorg/modelcar | jq -r '.manifests[] | select(.platform.architecture == "amd64") | .digest') | ||
| skopeo inspect --tls-verify=false docker://${OCI_REGISTRY_DESTINATION}@$digest --raw | jq -e '.layers | last | has("annotations")' | ||
| # tag amd64 as modelcar:v1 and load image in KinD cluster |
README.md
Outdated
Comment on lines
27
to
28
| # Appends to the image found in `download` the files `model.joblib` and as ModelCarD the `README.md` | ||
| poetry run olot $IMAGE_DIR tests/data/sample-model/model.joblib --modelcard tests/data/sample-model/README.md |
There was a problem hiding this comment.
perhaps to improve clarity, it might make sense to move the --modelcard ... snippet to before the "rest args". this is to ensure differentiation between a named-parameter vs the list of files that can be passed into olot
ie: poetry run olot $IMAGE_DIR --modelcard tests/data/sample-model/README.md tests/data/sample-model/model.joblib
wdyt?
Signed-off-by: tarilabs <[email protected]>
jaideepr97
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.