Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: extract /models content from ModelCar #13

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

tarilabs
Copy link
Member

There has been a request for ad-hoc extraction of the KServe ModelCar contents. This adds an utility for fit for the purpose (again relying on oci-layout on disk as provided by skopeo or similar).

@tarilabs tarilabs requested a review from jaideepr97 February 12, 2025 14:24
Copy link
Contributor

@Crazyglue Crazyglue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Collaborator

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to approve
just one question

return the output as a list instead of printing

Signed-off-by: tarilabs <[email protected]>
@jaideepr97 jaideepr97 merged commit 5042c27 into main Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants