Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create empty config file #10

Merged
merged 1 commit into from
Jan 23, 2025
Merged

create empty config file #10

merged 1 commit into from
Jan 23, 2025

Conversation

jaideepr97
Copy link
Collaborator

No description provided.

@jaideepr97 jaideepr97 force-pushed the oci-artifact-e2e branch 3 times, most recently from 97dc3ea to 0adeb9e Compare January 23, 2025 07:34
Signed-off-by: Jaideep Rao <[email protected]>
@jaideepr97 jaideepr97 changed the title create oci image layout from supplied model create empty config file Jan 23, 2025
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, I'm favourable of merging this early for you to ease work on

olot/oci_artifact.py

to make it hopefully easier, will also use merge-commit

)
manifest_json = json.dumps(manifest.model_dump(), indent=4, sort_keys=True)
manifest_json = json.dumps(manifest.dict(exclude_none=True), indent=4, sort_keys=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

)
]
)
index_json = json.dumps(index.model_dump(), indent=4, sort_keys=True)
index_json = json.dumps(index.dict(exclude_none=True), indent=4, sort_keys=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tarilabs tarilabs merged commit 4a01f8e into main Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants